Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 665203006: Revert of Reland "Integrate SIMD optimisations for zlib" (Closed)

Created:
6 years, 1 month ago by qyearsley
Modified:
6 years, 1 month ago
Reviewers:
hans, agl, robert.bradford
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Integrate SIMD optimisations for zlib" (patchset #2 id:40001 of https://codereview.chromium.org/677713002/) Reason for revert: Speculatively reverting because XP Tests (1) is having failures. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1) Original issue's description: > Reland "Integrate SIMD optimisations for zlib" > > This reland adds an MSan suppression entry to work around gaps in MSan's > support for some of the intrinsics this patch uses. This version also inlines > the insert_string_sse function as it uses inline assembly and therefore does > not need to be in the static library. > > Original CL: https://codereview.chromium.org/552123005 > > These optimisations have been published on zlib mailing list and at > https://github.com/jtkukunas/zlib/ > > This change merges the following optimisation patches: > - "For x86, add CPUID check." > - "Adds SSE2 optimized hash shifting to fill_window." > - "add SSE4.2 optimized hash function" > - "add PCLMULQDQ optimized CRC folding" > > From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the > current zlib version in Chromium. > > The optimisations are enabled at runtime if all the necessary CPU features are > present. As the optimisations require extra cflags to enable the compiler to > use the instructions the optimisations are held in their own static library > with a stub implementation to allow linking on other platforms. > > TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance > improvement seen on RoboHornet benchmark on Linux Desktop > BUG=401517 > > Committed: https://crrev.com/a5022d5eab6f77889aceed6ab0ccaf44a657ffc4 > Cr-Commit-Position: refs/heads/master@{#301162} TBR=agl@chromium.org,hans@chromium.org,robert.bradford@intel.com NOTREECHECKS=true NOTRY=true BUG=401517 Committed: https://crrev.com/5d38e0bd32f9a7e4766b877711c710df986d74ed Cr-Commit-Position: refs/heads/master@{#301221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1190 lines) Patch
M net/spdy/spdy_framer_test.cc View 4 chunks +7 lines, -166 lines 0 comments Download
M third_party/zlib/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M third_party/zlib/README.chromium View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/zlib/crc32.c View 2 chunks +0 lines, -27 lines 0 comments Download
D third_party/zlib/crc_folding.c View 1 chunk +0 lines, -493 lines 0 comments Download
M third_party/zlib/deflate.h View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/zlib/deflate.c View 19 chunks +29 lines, -116 lines 0 comments Download
D third_party/zlib/fill_window_sse.c View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/zlib/simd_stub.c View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/zlib/x86.h View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/zlib/x86.c View 1 chunk +0 lines, -90 lines 0 comments Download
M third_party/zlib/zlib.gyp View 3 chunks +0 lines, -23 lines 0 comments Download
M third_party/zlib/zutil.h View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qyearsley
Created Revert of Reland "Integrate SIMD optimisations for zlib"
6 years, 1 month ago (2014-10-24 23:04:14 UTC) #1
agl
lgtm
6 years, 1 month ago (2014-10-24 23:04:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665203006/1
6 years, 1 month ago (2014-10-24 23:07:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 23:09:54 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 23:10:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d38e0bd32f9a7e4766b877711c710df986d74ed
Cr-Commit-Position: refs/heads/master@{#301221}

Powered by Google App Engine
This is Rietveld 408576698