chrome/browser/download/chrome_download_manager_delegate.cc - Issue 665163005: Add option to open PDFs in system viewer to OS X and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 665163005: Add option to open PDFs in system viewer to OS X and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify the various identifiers for less #ifdefing. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/download/download_prefs.h » ('j') | chrome/browser/download/download_shelf_context_menu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/chrome_download_manager_delegate.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc

index 02dfa642a06abbff709e9c7deebdade13f726739..0bd26680d971d45f728e42f974a17ef58ef09dc0 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate.cc

@@ -711,11 +711,10 @@ void ChromeDownloadManagerDelegate::OnDownloadTargetDetermined(

bool ChromeDownloadManagerDelegate::IsOpenInBrowserPreferreredForFile(

const base::FilePath& path) {

- // On Windows, PDFs should open in Acrobat Reader if the user chooses.

-#if defined(OS_WIN)

- if (path.MatchesExtension(FILE_PATH_LITERAL(".pdf")) &&

- DownloadTargetDeterminer::IsAdobeReaderUpToDate()) {

- return !download_prefs_->ShouldOpenPdfInAdobeReader();

+#if defined(OS_WIN) || defined(OS_LINUX) || \

+ (defined(OS_MACOSX) && !defined(OS_IOS))

+ if (path.MatchesExtension(FILE_PATH_LITERAL(".pdf"))) {

+ return !download_prefs_->ShouldOpenPdfInSystemReader();

}

#endif

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/download/download_prefs.h » ('j') | chrome/browser/download/download_shelf_context_menu.cc » ('J')