Add option to open PDFs in system viewer to OS X and Linux.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 1445 matching lines @@
 // renderer's in-memory cache of objects.
 const char kMemoryCacheSize[] = "renderer.memory_cache.size";
 
 // String which specifies where to download files to by default.
 const char kDownloadDefaultDirectory[] = "download.default_directory";
 
 // Boolean that records if the download directory was changed by an
 // upgrade a unsafe location to a safe location.
 const char kDownloadDirUpgraded[] = "download.directory_upgrade";
 
-#if defined(OS_WIN)
-// Whether downloaded PDFs should be opened in Adobe Acrobat Reader.
-const char kOpenPdfDownloadInAdobeReader[] =
-    "download.open_pdf_in_adobe_reader";

[asanka, 2014/10/23 07:38:04]

This change has the effect of resetting the "Open in <...>" preference for PDFs.
I recall having to add migration code when this cropped up before so that users
who have explicitly set their preference won't notice any change in behavior.

[palmer, 2014/10/23 22:17:08]

Should leave the name the same for Windows? Or have both names, and make them
synonyms?

+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
+const char kOpenPdfDownloadInSystemReader[] =
+    "download.open_pdf_in_system_reader";
 #endif
 
 // String which specifies where to save html files to by default.
 const char kSaveFileDefaultDirectory[] = "savefile.default_directory";
 
 // The type used to save the page. See the enum SavePackage::SavePackageType in
 // the chrome/browser/download/save_package.h for the possible values.
 const char kSaveFileType[] = "savefile.type";
 
 // String which specifies the last directory that was chosen for uploading
@@ skipping 863 matching lines @@
 // Whether Guest Mode is enabled within the browser.
 const char kBrowserGuestModeEnabled[] = "profile.browser_guest_enabled";
 
 // Whether Adding a new Person is enabled within the user manager.
 const char kBrowserAddPersonEnabled[] = "profile.add_person_enabled";
 
 // A dictionary that maps user id to hardlock state.
 const char kEasyUnlockHardlockState[] = "easy_unlock.hardlock_state";
 
 }  // namespace prefs