Add option to open PDFs in system viewer to OS X and Linux.

chrome/browser/download/download_shelf_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_shelf_context_menu.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_item_model.h"
@@ skipping 104 matching lines @@
 
 bool DownloadShelfContextMenu::IsCommandIdChecked(int command_id) const {
   if (!download_item_)
     return false;
 
   switch (command_id) {
     case OPEN_WHEN_COMPLETE:
       return download_item_->GetOpenWhenComplete() ||
           download_crx_util::IsExtensionDownload(*download_item_);
     case ALWAYS_OPEN_TYPE:
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
       if (CanOpenPdfInReader()) {
         DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
             download_item_->GetBrowserContext());
-        return prefs->ShouldOpenPdfInAdobeReader();
+        return prefs->ShouldOpenPdfInSystemReader();
       }
 #endif
       return download_item_->ShouldOpenFileBasedOnExtension();
     case TOGGLE_PAUSE:
       return download_item_->IsPaused();
   }
   return false;
 }
 
 bool DownloadShelfContextMenu::IsCommandIdVisible(int command_id) const {
@@ skipping 14 matching lines @@
     case SHOW_IN_FOLDER:
       download_item_->ShowDownloadInShell();
       break;
     case OPEN_WHEN_COMPLETE:
       download_item_->OpenDownload();
       break;
     case ALWAYS_OPEN_TYPE: {
       bool is_checked = IsCommandIdChecked(ALWAYS_OPEN_TYPE);
       DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
           download_item_->GetBrowserContext());
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
       if (CanOpenPdfInReader()) {
-        prefs->SetShouldOpenPdfInAdobeReader(!is_checked);
+        prefs->SetShouldOpenPdfInSystemReader(!is_checked);
         DownloadItemModel(download_item_).SetShouldPreferOpeningInBrowser(
             is_checked);
         break;
       }
 #endif
       base::FilePath path = download_item_->GetTargetFilePath();
       if (is_checked)
         prefs->DisableAutoOpenBasedOnExtension(path);
       else
         prefs->EnableAutoOpenBasedOnExtension(path);
@@ skipping 204 matching lines @@
   malicious_download_menu_model_->AddItemWithStringId(
       LEARN_MORE_SCANNING, IDS_DOWNLOAD_MENU_LEARN_MORE_SCANNING);
 
   return malicious_download_menu_model_.get();
 }
 
 int DownloadShelfContextMenu::GetAlwaysOpenStringId() const {
 #if defined(OS_WIN)
   if (CanOpenPdfInReader())
     return IDS_DOWNLOAD_MENU_ALWAYS_OPEN_PDF_IN_READER;
+#elif defined(OS_MACOSX) || defined(OS_LINUX)
+  if (CanOpenPdfInReader())
+    return IDS_DOWNLOAD_MENU_PLATFORM_OPEN_ALWAYS;
 #endif
   return IDS_DOWNLOAD_MENU_ALWAYS_OPEN_TYPE;
 }
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
 bool DownloadShelfContextMenu::IsDownloadPdf() const {
   base::FilePath path = download_item_->GetTargetFilePath();
   return path.MatchesExtension(FILE_PATH_LITERAL(".pdf"));
 }
+#endif
 
+#if defined(OS_WIN)
 bool DownloadShelfContextMenu::CanOpenPdfInReader() const {

[asanka, 2014/10/23 07:38:04]

CanOpenPdfInSystemViewer?

[palmer, 2014/10/23 22:17:08]

OK, changed the name.

   return (is_pdf_reader_up_to_date_ && IsDownloadPdf());
 }
+#elif defined(OS_MACOSX) || defined(OS_LINUX)
+bool DownloadShelfContextMenu::CanOpenPdfInReader() const {
+  return IsDownloadPdf();
+}
 #endif