Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/enhanced_bookmarks/bookmark_server_service.h

Issue 665133004: Skip enhanced bookmarks cluster requests if it's not being used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment update Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/bookmark_server_service.h
diff --git a/components/enhanced_bookmarks/bookmark_server_service.h b/components/enhanced_bookmarks/bookmark_server_service.h
index d8cba89b66fcf39f04b0141b13e844779fe73060..42e848dad699e68fb645f3317946c4199112a91f 100644
--- a/components/enhanced_bookmarks/bookmark_server_service.h
+++ b/components/enhanced_bookmarks/bookmark_server_service.h
@@ -47,7 +47,7 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
EnhancedBookmarkModel* enhanced_bookmark_model);
virtual ~BookmarkServerService();
- void AddObserver(BookmarkServerServiceObserver* observer);
+ virtual void AddObserver(BookmarkServerServiceObserver* observer);
void RemoveObserver(BookmarkServerServiceObserver* observer);
protected:
@@ -84,6 +84,10 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
// Cached pointer to the bookmarks model.
EnhancedBookmarkModel* model_; // weak
+ protected:
+ // The observers.
+ ObserverList<BookmarkServerServiceObserver> observers_;
+
private:
FRIEND_TEST_ALL_PREFIXES(BookmarkServerServiceTest, Cluster);
FRIEND_TEST_ALL_PREFIXES(BookmarkServerServiceTest, SignOut);
@@ -100,8 +104,6 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
const GoogleServiceAuthError& error) override;
- // The observers.
- ObserverList<BookmarkServerServiceObserver> observers_;
// The Auth service is used to get a token for auth with the server.
ProfileOAuth2TokenService* token_service_; // Weak
// The request to the token service.
« no previous file with comments | « chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698