components/enhanced_bookmarks/bookmark_server_service.h - Issue 665133004: Skip enhanced bookmarks cluster requests if it's not being used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/bookmark_server_service.h

Issue 665133004: Skip enhanced bookmarks cluster requests if it's not being used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc ('K') | « chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc ('k') | components/enhanced_bookmarks/bookmark_server_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/enhanced_bookmarks/bookmark_server_service.h

diff --git a/components/enhanced_bookmarks/bookmark_server_service.h b/components/enhanced_bookmarks/bookmark_server_service.h

index d8cba89b66fcf39f04b0141b13e844779fe73060..453ffd1bbc94eff98e7900930a3bee7b86a7f210 100644

--- a/components/enhanced_bookmarks/bookmark_server_service.h

+++ b/components/enhanced_bookmarks/bookmark_server_service.h

@@ -47,8 +47,9 @@ class BookmarkServerService : protected net::URLFetcherDelegate,

EnhancedBookmarkModel* enhanced_bookmark_model);

virtual ~BookmarkServerService();

- void AddObserver(BookmarkServerServiceObserver* observer);

+ virtual void AddObserver(BookmarkServerServiceObserver* observer);

void RemoveObserver(BookmarkServerServiceObserver* observer);

+ bool MightHaveObservers();

danduong 2014/10/20 18:45:38 Any reason we don't just expose observers as prote

Kibeom Kim (inactive) 2014/10/20 20:05:47 Done.

protected:

// Retrieves a bookmark by using its remote id. Returns null if nothing