Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5179)

Unified Diff: chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h

Issue 665133004: Skip enhanced bookmarks cluster requests if it's not being used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h
diff --git a/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h b/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h
index 71820e908360ea78d219445f564b34a5e7715d33..47d18fd3c5e1027842b39ddcc53349eae36b0e77 100644
--- a/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h
+++ b/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h
@@ -26,6 +26,9 @@ class ChromeBookmarkServerClusterService : public BookmarkServerClusterService,
ProfileSyncService* sync_service);
virtual ~ChromeBookmarkServerClusterService();
+ // BookmarkServerClusterService
+ virtual void AddObserver(BookmarkServerServiceObserver* observer);
Mark 2014/10/20 18:40:43 I take it this still needs to be wired up somewher
danduong 2014/10/20 18:45:38 Do we want an override keyword here?
Kibeom Kim (inactive) 2014/10/20 20:05:47 override Done. Yes we're calling |AddObserver(...
+
// ProfileSyncServiceObserver implementation.
virtual void OnStateChanged() override;
virtual void OnSyncCycleCompleted() override;
@@ -33,6 +36,7 @@ class ChromeBookmarkServerClusterService : public BookmarkServerClusterService,
private:
// This class observes the sync service for changes.
ProfileSyncService* sync_service_;
+ bool sync_refresh_skipped_ = false;
DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkServerClusterService);
};

Powered by Google App Engine
This is Rietveld 408576698