Skip enhanced bookmarks cluster requests if it's not being used.

chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h"
 
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "components/enhanced_bookmarks/enhanced_bookmark_model.h"
 
 namespace enhanced_bookmarks {
@@ skipping 15 matching lines @@
       sync_service_(sync_service) {
   if (sync_service_)
     sync_service_->AddObserver(this);
 }
 
 ChromeBookmarkServerClusterService::~ChromeBookmarkServerClusterService() {
   if (sync_service_)
     sync_service_->RemoveObserver(this);
 }
 
+void ChromeBookmarkServerClusterService::AddObserver(
+    BookmarkServerServiceObserver* observer) {
+  BookmarkServerClusterService::AddObserver(observer);
+  if (sync_refresh_skipped_) {
+    sync_refresh_skipped_ = false;
+    TriggerTokenRequest(false);
+  }
+}
+
 void ChromeBookmarkServerClusterService::OnStateChanged() {
   // Do nothing.
 }
 
 void ChromeBookmarkServerClusterService::OnSyncCycleCompleted() {

[danduong, 2014/10/20 21:05:20]

I guess my real concern with this is that we'll check for updates to clusters
even if there haven't been any changes to bookmarks.  As far as I understand,
SyncCycleCompleted will happen for all sync cycle events. Which may or may not
be triggered by actual changes to bookmarks (there is a periodic timer that
polls for changes for instance).

I think we'd want an event is more directly related to bookmark changes from
sync. But even as the code is, it is already better than what we had previously.

[Kibeom Kim (inactive), 2014/10/21 00:40:33]

discussed offline, and we decided to just comment it for now.

   // The stars cluster API relies on the information in chrome-sync. Sending a
   // cluster request immediately after a bookmark is changed from the bookmark
   // observer notification will yield the wrong results. The request must be
   // delayed until the sync cycle has completed.
-  // TODO(noyau): This might happen too often, need a way to coalesce and delay
-  // the notifications.
-  if (model_->loaded())
-    TriggerTokenRequest(false);
+  if (model_->loaded()) {
+    if (observers_.might_have_observers()) {
+      TriggerTokenRequest(false);
+      sync_refresh_skipped_ = false;
+    } else {
+      sync_refresh_skipped_ = true;
+    }
+  }
 }
 
 }  // namespace enhanced_bookmarks