content/browser/gpu/gpu_data_manager_impl_private.cc - Issue 665123002: [DevTools] Move SystemInfo domain to generated handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 665123002: [DevTools] Move SystemInfo domain to generated handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browserProtocol

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/system_info_handler.cc ('K') | « content/browser/gpu/gpu_data_manager_impl_private.h ('k') | content/browser/gpu/gpu_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_data_manager_impl_private.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc

index 2c3790f60c4ffd0ea476e9205158bb731baffe72..0aafccf2a96a634f8df77ef50f9b29f792b8bde0 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc

@@ -756,14 +756,16 @@ void GpuDataManagerImplPrivate::GetBlacklistReasons(

gpu_driver_bug_list_->GetReasons(reasons, "workarounds");

}

-void GpuDataManagerImplPrivate::GetDriverBugWorkarounds(

- base::ListValue* workarounds) const {

+std::vector<std::string>

+GpuDataManagerImplPrivate::GetDriverBugWorkarounds() const {

+ std::vector<std::string> workarounds;

for (std::set<int>::const_iterator it = gpu_driver_bugs_.begin();

it != gpu_driver_bugs_.end(); ++it) {

- workarounds->AppendString(

+ workarounds.push_back(

gpu::GpuDriverBugWorkaroundTypeToString(

static_cast<gpu::GpuDriverBugWorkaroundType>(*it)));

}

+ return workarounds;

}

void GpuDataManagerImplPrivate::AddLogMessage(