Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 665113003: [WebUI] Cancel/OK order in donottrack overlay reversed (Closed)

Created:
6 years, 2 months ago by groby-ooo-7-16
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebUI] Cancel/OK order in donottrack overlay reversed Settings overlays are generally cancel/OK, donottrack was OK/cancel. BUG=425141 R=dbeam@chromium.org Committed: https://crrev.com/18d0a569464ac036813f190013df52848164e43d Cr-Commit-Position: refs/heads/master@{#300305}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/options/do_not_track_confirm_overlay.html View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
groby-ooo-7-16
6 years, 2 months ago (2014-10-20 16:11:24 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/665113003/diff/1/chrome/browser/resources/options/do_not_track_confirm_overlay.html File chrome/browser/resources/options/do_not_track_confirm_overlay.html (right): https://codereview.chromium.org/665113003/diff/1/chrome/browser/resources/options/do_not_track_confirm_overlay.html#newcode19 chrome/browser/resources/options/do_not_track_confirm_overlay.html:19: class="cancel-button"> nit: seems like class="cancel-button" may be useless
6 years, 2 months ago (2014-10-20 18:00:38 UTC) #2
groby-ooo-7-16
It seems so... I'll kill it w/ a second CL, just in case we need ...
6 years, 2 months ago (2014-10-20 18:15:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665113003/1
6 years, 2 months ago (2014-10-20 18:16:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 18:53:06 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 18:53:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18d0a569464ac036813f190013df52848164e43d
Cr-Commit-Position: refs/heads/master@{#300305}

Powered by Google App Engine
This is Rietveld 408576698