Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Issue 665103002: Dilate approximated text bounds to squelch recent assertion failure. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Dilate approximated text bounds to squelch recent assertion failure. This is once again an issue related to logo fonts, so I don't see any easy way to add a regression test for this. BUG=424824 Committed: https://skia.googlesource.com/skia/+/41966d49b0cc9dd2250dac4417ed3b365fb6d704

Patch Set 1 #

Patch Set 2 : update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein_C
6 years, 2 months ago (2014-10-20 15:56:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665103002/1
6 years, 2 months ago (2014-10-20 16:33:10 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 16:33:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/121)
6 years, 2 months ago (2014-10-20 16:39:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665103002/20001
6 years, 2 months ago (2014-10-20 18:47:49 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 18:47:50 UTC) #10
reed1
lgtm
6 years, 2 months ago (2014-10-20 20:43:37 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:44:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 41966d49b0cc9dd2250dac4417ed3b365fb6d704

Powered by Google App Engine
This is Rietveld 408576698