ABANDONED Handle multiple AlternateProtocols for each HostPortPair.

net/http/http_stream_factory_impl_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 149 matching lines @@
     case STATE_INIT_CONNECTION_COMPLETE:
     case STATE_CREATE_STREAM_COMPLETE:
       return using_quic_ ? LOAD_STATE_CONNECTING : connection_->GetLoadState();
     default:
       return LOAD_STATE_IDLE;
   }
 }
 
 void HttpStreamFactoryImpl::Job::MarkAsAlternate(
     const GURL& original_url,
     AlternateProtocolInfo alternate) {

[Ryan Hamilton, 2015/02/27 18:20:48]

As discussed yesterday, this should probably take the full list of alternatives
so that it can check active QUIC and SPDY sessions for existing entries.

[Bence, 2015/02/27 19:31:41]

Acknowledged.

By the way, what guarantees that Job::DoInitConnection is executed _after_
MarkAsAlternate is called?  (Otherwise the logic we are planting there will not
work as intended!)

   DCHECK(!original_url_.get());
   original_url_.reset(new GURL(original_url));
   alternate_protocol_ = alternate;
   if (alternate.protocol == QUIC) {
     DCHECK(session_->params().enable_quic);
     using_quic_ = true;
   }
 }
 
 void HttpStreamFactoryImpl::Job::WaitFor(Job* job) {
@@ skipping 1339 matching lines @@
 void HttpStreamFactoryImpl::Job::MaybeMarkAlternateProtocolBroken() {
   if (job_status_ == STATUS_RUNNING || other_job_status_ == STATUS_RUNNING)
     return;
 
   bool is_alternate_protocol_job = original_url_.get() != NULL;
   if (is_alternate_protocol_job) {
     if (job_status_ == STATUS_BROKEN && other_job_status_ == STATUS_SUCCEEDED) {
       HistogramBrokenAlternateProtocolLocation(
           BROKEN_ALTERNATE_PROTOCOL_LOCATION_HTTP_STREAM_FACTORY_IMPL_JOB_ALT);
       session_->http_server_properties()->SetBrokenAlternateProtocol(
-          HostPortPair::FromURL(*original_url_));
+          HostPortPair::FromURL(*original_url_), alternate_protocol_);
     }
     return;
   }
 
   if (job_status_ == STATUS_SUCCEEDED && other_job_status_ == STATUS_BROKEN) {
     HistogramBrokenAlternateProtocolLocation(
         BROKEN_ALTERNATE_PROTOCOL_LOCATION_HTTP_STREAM_FACTORY_IMPL_JOB_MAIN);
     session_->http_server_properties()->SetBrokenAlternateProtocol(
-        HostPortPair::FromURL(request_info_.url));
+        HostPortPair::FromURL(request_info_.url),
+        other_job_alternate_protocol_);
   }
 }
 
 }  // namespace net