ABANDONED Handle multiple AlternateProtocols for each HostPortPair.

net/http/http_stream_factory_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 153 matching lines @@
                   server_ssl_config, proxy_ssl_config, session_->net_log());
   }
   preconnect_job_set_.insert(job);
   job->Preconnect(num_streams);
 }
 
 const HostMappingRules* HttpStreamFactoryImpl::GetHostMappingRules() const {
   return session_->params().host_mapping_rules;
 }
 
 AlternateProtocolInfo HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(

[Ryan Hamilton, 2015/02/27 18:20:48]

As discussed yesterday, I think this needs to return all the alternates. It
should probably filter the list in the same way that it currently exclude some
alternate protocols.

[Bence, 2015/02/27 19:31:41]

Absolutely.  Now even after this CL we can only have one alternate protocol for
each server, can I do that in a separate CL?

     const GURL& original_url,
     GURL* alternate_url) {
   const AlternateProtocolInfo kNoAlternateProtocol;
 
   if (!session_->params().use_alternate_protocols)
     return kNoAlternateProtocol;
 
   if (original_url.SchemeIs("ftp"))
     return kNoAlternateProtocol;
 
   HostPortPair origin = HostPortPair::FromURL(original_url);
   HttpServerProperties& http_server_properties =
       *session_->http_server_properties();
-  const AlternateProtocolInfo alternate =
-      http_server_properties.GetAlternateProtocol(origin);
+  AlternateProtocols alternate_protocols =
+      http_server_properties.GetAlternateProtocols(origin);
+  if (alternate_protocols.empty())
+    return kNoAlternateProtocol;
+  for (AlternateProtocols::iterator alternate = alternate_protocols.begin();
+       alternate != alternate_protocols.end(); ++alternate) {

[Ryan Hamilton, 2015/02/27 18:20:48]

Can you use a C++ range based for loop here?

[Bence, 2015/02/27 19:31:41]

Done.

+    if (alternate->is_broken) {
+      HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_BROKEN);
+      continue;
+    }
 
-  if (alternate.protocol == UNINITIALIZED_ALTERNATE_PROTOCOL)
-    return kNoAlternateProtocol;
-  if (alternate.is_broken) {
-    HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_BROKEN);
-    return kNoAlternateProtocol;
+    // Some shared unix systems may have user home directories (like
+    // http://foo.com/~mike) which allow users to emit headers.  This is a bad
+    // idea already, but with Alternate-Protocol, it provides the ability for a
+    // single user on a multi-user system to hijack the alternate protocol.
+    // These systems also enforce ports <1024 as restricted ports.  So don't
+    // allow protocol upgrades to user-controllable ports.
+    const int kUnrestrictedPort = 1024;
+    if (!session_->params().enable_user_alternate_protocol_ports &&
+        (alternate->port >= kUnrestrictedPort &&
+         origin.port() < kUnrestrictedPort))
+      continue;
+
+    origin.set_port(alternate->port);
+    if (alternate->protocol >= NPN_SPDY_MINIMUM_VERSION &&
+        alternate->protocol <= NPN_SPDY_MAXIMUM_VERSION) {
+      if (!HttpStreamFactory::spdy_enabled())
+        continue;
+
+      if (session_->HasSpdyExclusion(origin))
+        continue;
+
+      *alternate_url = UpgradeUrlToHttps(original_url, alternate->port);
+      return *alternate;
+    } else {
+      DCHECK_EQ(QUIC, alternate->protocol);
+      if (!session_->params().enable_quic)
+        continue;
+
+      // TODO(rch):  Figure out how to make QUIC iteract with PAC
+      // scripts.  By not re-writing the URL, we will query the PAC script
+      // for the proxy to use to reach the original URL via TCP.  But
+      // the alternate request will be going via UDP to a different port.
+      *alternate_url = original_url;
+      return *alternate;
+    }
   }
-  if (!IsAlternateProtocolValid(alternate.protocol)) {
-    NOTREACHED();
-    return kNoAlternateProtocol;
-  }
-
-  // Some shared unix systems may have user home directories (like
-  // http://foo.com/~mike) which allow users to emit headers.  This is a bad
-  // idea already, but with Alternate-Protocol, it provides the ability for a
-  // single user on a multi-user system to hijack the alternate protocol.
-  // These systems also enforce ports <1024 as restricted ports.  So don't
-  // allow protocol upgrades to user-controllable ports.
-  const int kUnrestrictedPort = 1024;
-  if (!session_->params().enable_user_alternate_protocol_ports &&
-      (alternate.port >= kUnrestrictedPort &&
-       origin.port() < kUnrestrictedPort))
-    return kNoAlternateProtocol;
-
-  origin.set_port(alternate.port);
-  if (alternate.protocol >= NPN_SPDY_MINIMUM_VERSION &&
-      alternate.protocol <= NPN_SPDY_MAXIMUM_VERSION) {
-    if (!HttpStreamFactory::spdy_enabled())
-      return kNoAlternateProtocol;
-
-    if (session_->HasSpdyExclusion(origin))
-      return kNoAlternateProtocol;
-
-    *alternate_url = UpgradeUrlToHttps(original_url, alternate.port);
-  } else {
-    DCHECK_EQ(QUIC, alternate.protocol);
-    if (!session_->params().enable_quic)
-      return kNoAlternateProtocol;
-
-    // TODO(rch):  Figure out how to make QUIC iteract with PAC
-    // scripts.  By not re-writing the URL, we will query the PAC script
-    // for the proxy to use to reach the original URL via TCP.  But
-    // the alternate request will be going via UDP to a different port.
-    *alternate_url = original_url;
-  }
-  return alternate;
+  return kNoAlternateProtocol;
 }
 
 void HttpStreamFactoryImpl::OrphanJob(Job* job, const Request* request) {
   DCHECK(ContainsKey(request_map_, job));
   DCHECK_EQ(request_map_[job], request);
   DCHECK(!ContainsKey(orphaned_job_set_, job));
 
   request_map_.erase(job);
 
   orphaned_job_set_.insert(job);
@@ skipping 48 matching lines @@
   delete job;
 }
 
 void HttpStreamFactoryImpl::OnPreconnectsComplete(const Job* job) {
   preconnect_job_set_.erase(job);
   delete job;
   OnPreconnectsCompleteInternal();
 }
 
 }  // namespace net