ABANDONED Handle multiple AlternateProtocols for each HostPortPair.

net/http/http_stream_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 68 matching lines @@
   }
 
   if (protocol == UNINITIALIZED_ALTERNATE_PROTOCOL)
     return;
 
   HostPortPair host_port(http_host_port_pair);
   const HostMappingRules* mapping_rules = GetHostMappingRules();
   if (mapping_rules)
     mapping_rules->RewriteHost(&host_port);
 
-  http_server_properties->SetAlternateProtocol(
+  http_server_properties->AddAlternateProtocol(
       host_port, static_cast<uint16>(port), protocol, probability);

[Ryan Hamilton, 2015/02/27 18:20:48]

I don't think this is quite right. Let's say that initially we have:
  Alternate-Protocol: QUIC:443
But then we see:
  Alternate-Protocol: npn-spdy:80
(This example is lame, but bear with me :>). I think that as written, this code
will end up with *both* mappings active, but I think we only want one. What do
you think?

[Bence, 2015/02/27 19:31:41]

You are right.  So we will have another method for parsing alternative services,
right?  And we want both ProcessAlternateProtocols and ProcessAlternateServices
to overwrite existing settings, right?

Done.

 }
 
 GURL HttpStreamFactory::ApplyHostMappingRules(const GURL& url,
                                               HostPortPair* endpoint) {
   const HostMappingRules* mapping_rules = GetHostMappingRules();
   if (mapping_rules && mapping_rules->RewriteHost(endpoint)) {
     url::Replacements<char> replacements;
     const std::string port_str = base::IntToString(endpoint->port());
     replacements.SetPort(port_str.c_str(), url::Component(0, port_str.size()));
     replacements.SetHost(endpoint->host().c_str(),
                          url::Component(0, endpoint->host().size()));
     return url.ReplaceComponents(replacements);
   }
   return url;
 }
 
 HttpStreamFactory::HttpStreamFactory() {}
 
 }  // namespace net