Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 665083002: DevTools: Fix Windows debug_devtools=1 builds (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix Windows debug_devtools=1 builds This patch eliminates the "Command line too long" errors when building on Windows in the debug_devtools=1 mode. Drive-by: Fix GN build after r183969 R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184003

Patch Set 1 #

Patch Set 2 : Fix variable type on command line in gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M Source/devtools/BUILD.gn View 5 chunks +11 lines, -7 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 3 chunks +20 lines, -16 lines 0 comments Download
M Source/devtools/scripts/generate_devtools_grd.py View 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
apavlov
6 years, 2 months ago (2014-10-20 14:40:41 UTC) #1
pfeldman
lgtm
6 years, 2 months ago (2014-10-20 14:51:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665083002/1
6 years, 2 months ago (2014-10-20 14:53:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/23338)
6 years, 2 months ago (2014-10-20 15:07:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665083002/40001
6 years, 2 months ago (2014-10-20 15:37:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27746)
6 years, 2 months ago (2014-10-20 17:09:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665083002/40001
6 years, 2 months ago (2014-10-20 17:50:37 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 18:56:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 184003

Powered by Google App Engine
This is Rietveld 408576698