Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 665063003: Use #import for ObjC headers. (Closed)

Created:
6 years, 2 months ago by groby-ooo-7-16
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use #import for ObjC headers. Minor style nit, but base_bubble_controller.h exposes ObjC APIs and should be included via #import, not #include. BUG=none Committed: https://crrev.com/65f68e0c6aa120a788ad9cfa5ed49064c80e909e Cr-Commit-Position: refs/heads/master@{#300413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
groby-ooo-7-16
Sorry - today is "annoy Dan with minuscule changes" day, it seems :) PTAL
6 years, 2 months ago (2014-10-21 02:55:09 UTC) #2
Dan Beam
lgtm
6 years, 2 months ago (2014-10-21 03:04:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665063003/1
6 years, 2 months ago (2014-10-21 03:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 03:30:38 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 03:34:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65f68e0c6aa120a788ad9cfa5ed49064c80e909e
Cr-Commit-Position: refs/heads/master@{#300413}

Powered by Google App Engine
This is Rietveld 408576698