Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 665033003: Removing Migraction code from M17 in session restore (Closed)

Created:
6 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, marja+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing Migraction code from M17 in session restore BUG=424679 TEST=- Committed: https://crrev.com/4c5156d32bedf8176a335aebb44adc2e5c377843 Cr-Commit-Position: refs/heads/master@{#300503}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comments #

Patch Set 3 : Removed the unit test which tested the migration code as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -64 lines) Patch
M chrome/browser/sessions/session_service.cc View 1 3 chunks +5 lines, -35 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Mr4D (OOO till 08-26)
Removing old M17 migration code as preparation for the SessionService refactoring / componentization.
6 years, 2 months ago (2014-10-20 21:51:55 UTC) #2
sky
LGTM https://codereview.chromium.org/665033003/diff/1/chrome/browser/sessions/session_service.cc File chrome/browser/sessions/session_service.cc (left): https://codereview.chromium.org/665033003/diff/1/chrome/browser/sessions/session_service.cc#oldcode63 chrome/browser/sessions/session_service.cc:63: // Original kCommandTabClosed/kCommandWindowClosed. See comment in Add a ...
6 years, 2 months ago (2014-10-20 22:27:32 UTC) #3
Mr4D (OOO till 08-26)
Done. Thanks!
6 years, 2 months ago (2014-10-20 22:52:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665033003/20001
6 years, 2 months ago (2014-10-20 22:55:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/25690)
6 years, 2 months ago (2014-10-21 00:07:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665033003/20001
6 years, 2 months ago (2014-10-21 03:23:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/25781)
6 years, 2 months ago (2014-10-21 04:52:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665033003/40001
6 years, 2 months ago (2014-10-21 14:42:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27634)
6 years, 2 months ago (2014-10-21 16:01:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665033003/40001
6 years, 2 months ago (2014-10-21 16:34:39 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-21 17:00:08 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:00:51 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4c5156d32bedf8176a335aebb44adc2e5c377843
Cr-Commit-Position: refs/heads/master@{#300503}

Powered by Google App Engine
This is Rietveld 408576698