Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 66503013: Support the 'lrm', 'rlm' and 'nbsp' entities in the WebVTTTokenizer (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support the 'lrm', 'rlm' and 'nbsp' entities in the WebVTTTokenizer TEST=media/track/track-webvtt-tc022-entities.html BUG=314028 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M LayoutTests/media/track/captions-webvtt/tc022-entities.vtt View 2 chunks +13 lines, -1 line 0 comments Download
M LayoutTests/media/track/track-webvtt-tc022-entities.html View 2 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/media/track/track-webvtt-tc022-entities-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTTokenizer.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
7 years, 1 month ago (2013-11-12 14:25:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-12 14:47:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/66503013/1
7 years, 1 month ago (2013-11-12 14:50:18 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 16:17:35 UTC) #4
Message was sent while issue was closed.
Change committed as 161822

Powered by Google App Engine
This is Rietveld 408576698