Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 66503004: win: fixes for using vs 2013 toolchain (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/MSVSVersion.py ('K') | « pylib/gyp/MSVSVersion.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/msvs_emulation.py
diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py
index 1d59e8beb2948c0489ae9e6a45deed37304bc873..2afc5052fb2addfe37262bcc5230bdbfb65cf97f 100644
--- a/pylib/gyp/msvs_emulation.py
+++ b/pylib/gyp/msvs_emulation.py
@@ -363,7 +363,8 @@ class MsvsSettings(object):
cl('AdditionalOptions', prefix='')
cflags.extend(['/FI' + f for f in self._Setting(
('VCCLCompilerTool', 'ForcedIncludeFiles'), config, default=[])])
- if self.vs_version.short_name == '2013' or self.vs_version == '2013e':
+ if (self.vs_version.short_name == '2013' or
+ self.vs_version.short_name == '2013e'):
scottmg 2013/11/08 21:43:39 This was just a typo. :/
Nico 2013/11/09 04:20:31 if self.vs_version.short_name in ['2013', '2013e']
scottmg 2013/11/09 04:47:33 Done.
# New flag required in 2013 to maintain previous PDB behavior.
cflags.append('/FS')
# ninja handles parallelism by itself, don't have the compiler do it too.
« pylib/gyp/MSVSVersion.py ('K') | « pylib/gyp/MSVSVersion.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698