Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 664983002: [gcc 4.x] Fix the build failure due to -Werror=char-subscripts (Closed)

Created:
6 years, 2 months ago by vivekg_samsung
Modified:
6 years, 2 months ago
CC:
chromium-reviews, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[gcc 4.x] Fix the build failure due to -Werror=char-subscripts Make the 'char' to 'unsigned char' to fix the following build failure. device/hid/hid_connection_unittest.cc: In member function ‘virtual void device::HidConnectionTest_ReadWrite_Test::TestBody()’: device/hid/hid_connection_unittest.cc:166:23: error: array subscript has type ‘char’ [-Werror=char-subscripts] buffer->data()[j] = i + j - 1; ^ device/hid/hid_connection_unittest.cc:179:285: error: array subscript has type ‘char’ [-Werror=char-subscripts] ASSERT_EQ(i + j - 1, read_callback.buffer()->data()[j]) Committed: https://crrev.com/3a9e7ea06f717789c3304ad4fc085e8f621a8088 Cr-Commit-Position: refs/heads/master@{#300238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M device/hid/hid_connection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
Please take a look, thanks.
6 years, 2 months ago (2014-10-20 03:45:43 UTC) #2
Reilly Grant (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-20 04:12:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664983002/1
6 years, 2 months ago (2014-10-20 04:51:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 09:36:06 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:37:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9e7ea06f717789c3304ad4fc085e8f621a8088
Cr-Commit-Position: refs/heads/master@{#300238}

Powered by Google App Engine
This is Rietveld 408576698