Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 664973002: X87: ReceiverCheckMode needs to be utilized further. (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: ReceiverCheckMode needs to be utilized further. port r24704. original commit message: ReceiverCheckMode needs to be utilized further. The parameter wasn't being passed appropriately, and there was an extra opportunity to use mode RECEIVER_IS_STRING in SubStringStub. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL. PTAL. thanks
6 years, 2 months ago (2014-10-20 02:56:17 UTC) #2
Weiliang
lgtm
6 years, 2 months ago (2014-10-20 02:57:20 UTC) #3
Weiliang
6 years, 2 months ago (2014-10-20 04:13:42 UTC) #4
Committed as 24714

Powered by Google App Engine
This is Rietveld 408576698