Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 664963003: Oilpan: Move CSSTimingData back to off-heap (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, rune+blink, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dstockwell, Timothy Loh, blink-reviews-rendering, jchaffraix+rendering, darktears, Steve Block, zoltan1, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Oilpan: Move CSSTimingData back to off-heap This CL improves performance of LayoutTests/Shapes/* by 2 - 3% by removing Persistent handles in StyleRareNonInheritedData.h. These Persistent handles are one of the bottlenecks of LayoutTests/Shapes/*. (That being said, there is still 5 - 8% regression in LayoutTests/Shapes/* even after this CL.) Since it's not easy to move StyleRareNonInheritedData.h to the heap without moving the entire RenderStyle hierarchy to the heap, this CL simply moves CSSTimingData back to off-heap. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183962

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M Source/core/animation/css/CSSAnimationData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/css/CSSTimingData.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-20 04:59:07 UTC) #2
sof
lgtm
6 years, 2 months ago (2014-10-20 05:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664963003/20001
6 years, 2 months ago (2014-10-20 05:09:34 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 06:04:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183962

Powered by Google App Engine
This is Rietveld 408576698