Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: extensions/renderer/render_view_observer_natives.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/render_view_observer_natives.cc
diff --git a/extensions/renderer/render_view_observer_natives.cc b/extensions/renderer/render_view_observer_natives.cc
index 1f2fb88cc0eb146d4512b768f20147dd2c3472b1..19a3974c1b8ad1743f77bbfd4061dd5fe139b5e9 100644
--- a/extensions/renderer/render_view_observer_natives.cc
+++ b/extensions/renderer/render_view_observer_natives.cc
@@ -23,13 +23,12 @@ class LoadWatcher : public content::RenderViewObserver {
v8::Handle<v8::Function> cb)
: content::RenderViewObserver(view), context_(context), callback_(cb) {}
- virtual void DidCreateDocumentElement(blink::WebLocalFrame* frame) override {
+ void DidCreateDocumentElement(blink::WebLocalFrame* frame) override {
CallbackAndDie(true);
}
- virtual void DidFailProvisionalLoad(blink::WebLocalFrame* frame,
- const blink::WebURLError& error)
- override {
+ void DidFailProvisionalLoad(blink::WebLocalFrame* frame,
+ const blink::WebURLError& error) override {
CallbackAndDie(false);
}
« no previous file with comments | « extensions/renderer/programmatic_script_injector.h ('k') | extensions/renderer/resource_bundle_source_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698