Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: extensions/renderer/module_system.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/messaging_bindings.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system.h
diff --git a/extensions/renderer/module_system.h b/extensions/renderer/module_system.h
index 18263444f9bde6c82b01422d2e5fad02dc7b2cdd..51ecc95f91cd49c9febe7109cd33cc747ecf6e5e 100644
--- a/extensions/renderer/module_system.h
+++ b/extensions/renderer/module_system.h
@@ -72,7 +72,7 @@ class ModuleSystem : public ObjectBackedNativeHandler,
// |source_map| is a weak pointer.
ModuleSystem(ScriptContext* context, SourceMap* source_map);
- virtual ~ModuleSystem();
+ ~ModuleSystem() override;
// Require the specified module. This is the equivalent of calling
// require('module_name') from the loaded JS files.
@@ -143,7 +143,7 @@ class ModuleSystem : public ObjectBackedNativeHandler,
protected:
friend class ScriptContext;
- virtual void Invalidate() override;
+ void Invalidate() override;
private:
typedef std::map<std::string, linked_ptr<NativeHandler> > NativeHandlerMap;
@@ -202,7 +202,7 @@ class ModuleSystem : public ObjectBackedNativeHandler,
v8::Handle<v8::Value> value);
// gin::ModuleRegistryObserver overrides.
- virtual void OnDidAddPendingModule(
+ void OnDidAddPendingModule(
const std::string& id,
const std::vector<std::string>& dependencies) override;
« no previous file with comments | « extensions/renderer/messaging_bindings.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698