Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/common/manifest_url_handlers.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handlers/webview_info.h ('k') | extensions/common/permissions/api_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_url_handlers.h
diff --git a/extensions/common/manifest_url_handlers.h b/extensions/common/manifest_url_handlers.h
index 72b383356116100ab922375c6cb69409837f5d8f..2ca21d4e754ecbf6c16f6247e4f1759e95bc62c5 100644
--- a/extensions/common/manifest_url_handlers.h
+++ b/extensions/common/manifest_url_handlers.h
@@ -52,12 +52,12 @@ struct ManifestURL : public Extension::ManifestData {
class HomepageURLHandler : public ManifestHandler {
public:
HomepageURLHandler();
- virtual ~HomepageURLHandler();
+ ~HomepageURLHandler() override;
- virtual bool Parse(Extension* extension, base::string16* error) override;
+ bool Parse(Extension* extension, base::string16* error) override;
private:
- virtual const std::vector<std::string> Keys() const override;
+ const std::vector<std::string> Keys() const override;
DISALLOW_COPY_AND_ASSIGN(HomepageURLHandler);
};
@@ -66,12 +66,12 @@ class HomepageURLHandler : public ManifestHandler {
class UpdateURLHandler : public ManifestHandler {
public:
UpdateURLHandler();
- virtual ~UpdateURLHandler();
+ ~UpdateURLHandler() override;
- virtual bool Parse(Extension* extension, base::string16* error) override;
+ bool Parse(Extension* extension, base::string16* error) override;
private:
- virtual const std::vector<std::string> Keys() const override;
+ const std::vector<std::string> Keys() const override;
DISALLOW_COPY_AND_ASSIGN(UpdateURLHandler);
};
@@ -84,15 +84,15 @@ class UpdateURLHandler : public ManifestHandler {
class AboutPageHandler : public ManifestHandler {
public:
AboutPageHandler();
- virtual ~AboutPageHandler();
+ ~AboutPageHandler() override;
- virtual bool Parse(Extension* extension, base::string16* error) override;
- virtual bool Validate(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings) const override;
+ bool Parse(Extension* extension, base::string16* error) override;
+ bool Validate(const Extension* extension,
+ std::string* error,
+ std::vector<InstallWarning>* warnings) const override;
private:
- virtual const std::vector<std::string> Keys() const override;
+ const std::vector<std::string> Keys() const override;
DISALLOW_COPY_AND_ASSIGN(AboutPageHandler);
};
« no previous file with comments | « extensions/common/manifest_handlers/webview_info.h ('k') | extensions/common/permissions/api_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698