Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3524)

Unified Diff: extensions/browser/script_executor.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/runtime_data.h ('k') | extensions/browser/stash_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/script_executor.cc
diff --git a/extensions/browser/script_executor.cc b/extensions/browser/script_executor.cc
index 4df07981717bdf11802461211a7191da4a0fff86..70b837e2a6ad96219021a8c44cee3eecc882780c 100644
--- a/extensions/browser/script_executor.cc
+++ b/extensions/browser/script_executor.cc
@@ -45,9 +45,9 @@ class Handler : public content::WebContentsObserver {
rvh->Send(new ExtensionMsg_ExecuteCode(rvh->GetRoutingID(), params));
}
- virtual ~Handler() {}
+ ~Handler() override {}
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ bool OnMessageReceived(const IPC::Message& message) override {
// Unpack by hand to check the request_id, since there may be multiple
// requests in flight but only one is for this.
if (message.type() != ExtensionHostMsg_ExecuteCodeFinished::ID)
@@ -67,7 +67,7 @@ class Handler : public content::WebContentsObserver {
return true;
}
- virtual void WebContentsDestroyed() override {
+ void WebContentsDestroyed() override {
base::ListValue val;
callback_.Run(kRendererDestroyed, GURL(std::string()), val);
delete this;
« no previous file with comments | « extensions/browser/runtime_data.h ('k') | extensions/browser/stash_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698