Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
index cf35b5c88811f8272a80a0bde1bcce7846b89748..d788cb540d92895692a1ab0a14f25597d1ce5108 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
@@ -25,46 +25,45 @@ class MimeHandlerViewGuest : public GuestView<MimeHandlerViewGuest>,
static const char Type[];
// ExtensionFunctionDispatcher::Delegate implementation.
- virtual WindowController* GetExtensionWindowController() const override;
- virtual content::WebContents* GetAssociatedWebContents() const override;
+ WindowController* GetExtensionWindowController() const override;
+ content::WebContents* GetAssociatedWebContents() const override;
// GuestViewBase implementation.
- virtual const char* GetAPINamespace() const override;
- virtual int GetTaskPrefix() const override;
- virtual void CreateWebContents(
- const std::string& embedder_extension_id,
- int embedder_render_process_id,
- const GURL& embedder_site_url,
- const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) override;
- virtual void DidAttachToEmbedder() override;
- virtual void DidInitialize() override;
+ const char* GetAPINamespace() const override;
+ int GetTaskPrefix() const override;
+ void CreateWebContents(const std::string& embedder_extension_id,
+ int embedder_render_process_id,
+ const GURL& embedder_site_url,
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) override;
+ void DidAttachToEmbedder() override;
+ void DidInitialize() override;
// content::BrowserPluginGuestDelegate implementation
- virtual bool Find(int request_id,
- const base::string16& search_text,
- const blink::WebFindOptions& options,
- bool is_full_page_plugin) override;
+ bool Find(int request_id,
+ const base::string16& search_text,
+ const blink::WebFindOptions& options,
+ bool is_full_page_plugin) override;
// WebContentsDelegate implementation.
- virtual void ContentsZoomChange(bool zoom_in) override;
- virtual void HandleKeyboardEvent(
+ void ContentsZoomChange(bool zoom_in) override;
+ void HandleKeyboardEvent(
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) override;
- virtual void FindReply(content::WebContents* web_contents,
- int request_id,
- int number_of_matches,
- const gfx::Rect& selection_rect,
- int active_match_ordinal,
- bool final_update) override;
+ void FindReply(content::WebContents* web_contents,
+ int request_id,
+ int number_of_matches,
+ const gfx::Rect& selection_rect,
+ int active_match_ordinal,
+ bool final_update) override;
// content::WebContentsObserver implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
private:
MimeHandlerViewGuest(content::BrowserContext* browser_context,
int guest_instance_id);
- virtual ~MimeHandlerViewGuest();
+ ~MimeHandlerViewGuest() override;
void OnRequest(const ExtensionHostMsg_Request_Params& params);
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.h ('k') | extensions/browser/guest_view/test_guest_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698