Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: extensions/browser/api/storage/storage_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/storage/storage_api.h
diff --git a/extensions/browser/api/storage/storage_api.h b/extensions/browser/api/storage/storage_api.h
index b3544fa80624cf1f2132023a0429032ce4efe587..0a750697bfc7db6535065b78f9aa98bfcab1651c 100644
--- a/extensions/browser/api/storage/storage_api.h
+++ b/extensions/browser/api/storage/storage_api.h
@@ -18,11 +18,11 @@ namespace extensions {
class SettingsFunction : public UIThreadExtensionFunction {
protected:
SettingsFunction();
- virtual ~SettingsFunction();
+ ~SettingsFunction() override;
// ExtensionFunction:
- virtual bool ShouldSkipQuotaLimiting() const override;
- virtual ResponseAction Run() override;
+ bool ShouldSkipQuotaLimiting() const override;
+ ResponseAction Run() override;
// Extension settings function implementations should do their work here.
// The StorageFrontend makes sure this is posted to the appropriate thread.
@@ -77,10 +77,10 @@ class StorageStorageAreaGetFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION("storage.get", STORAGE_GET)
protected:
- virtual ~StorageStorageAreaGetFunction() {}
+ ~StorageStorageAreaGetFunction() override {}
// SettingsFunction:
- virtual ResponseValue RunWithStorage(ValueStore* storage) override;
+ ResponseValue RunWithStorage(ValueStore* storage) override;
};
class StorageStorageAreaSetFunction : public SettingsFunction {
@@ -88,14 +88,13 @@ class StorageStorageAreaSetFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION("storage.set", STORAGE_SET)
protected:
- virtual ~StorageStorageAreaSetFunction() {}
+ ~StorageStorageAreaSetFunction() override {}
// SettingsFunction:
- virtual ResponseValue RunWithStorage(ValueStore* storage) override;
+ ResponseValue RunWithStorage(ValueStore* storage) override;
// ExtensionFunction:
- virtual void GetQuotaLimitHeuristics(
- QuotaLimitHeuristics* heuristics) const override;
+ void GetQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) const override;
};
class StorageStorageAreaRemoveFunction : public SettingsFunction {
@@ -103,14 +102,13 @@ class StorageStorageAreaRemoveFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION("storage.remove", STORAGE_REMOVE)
protected:
- virtual ~StorageStorageAreaRemoveFunction() {}
+ ~StorageStorageAreaRemoveFunction() override {}
// SettingsFunction:
- virtual ResponseValue RunWithStorage(ValueStore* storage) override;
+ ResponseValue RunWithStorage(ValueStore* storage) override;
// ExtensionFunction:
- virtual void GetQuotaLimitHeuristics(
- QuotaLimitHeuristics* heuristics) const override;
+ void GetQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) const override;
};
class StorageStorageAreaClearFunction : public SettingsFunction {
@@ -118,14 +116,13 @@ class StorageStorageAreaClearFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION("storage.clear", STORAGE_CLEAR)
protected:
- virtual ~StorageStorageAreaClearFunction() {}
+ ~StorageStorageAreaClearFunction() override {}
// SettingsFunction:
- virtual ResponseValue RunWithStorage(ValueStore* storage) override;
+ ResponseValue RunWithStorage(ValueStore* storage) override;
// ExtensionFunction:
- virtual void GetQuotaLimitHeuristics(
- QuotaLimitHeuristics* heuristics) const override;
+ void GetQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) const override;
};
class StorageStorageAreaGetBytesInUseFunction : public SettingsFunction {
@@ -133,10 +130,10 @@ class StorageStorageAreaGetBytesInUseFunction : public SettingsFunction {
DECLARE_EXTENSION_FUNCTION("storage.getBytesInUse", STORAGE_GETBYTESINUSE)
protected:
- virtual ~StorageStorageAreaGetBytesInUseFunction() {}
+ ~StorageStorageAreaGetBytesInUseFunction() override {}
// SettingsFunction:
- virtual ResponseValue RunWithStorage(ValueStore* storage) override;
+ ResponseValue RunWithStorage(ValueStore* storage) override;
};
} // namespace extensions
« no previous file with comments | « extensions/browser/api/storage/settings_test_util.h ('k') | extensions/browser/api/storage/storage_frontend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698