Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: extensions/browser/api/socket/udp_socket.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/socket/tls_socket.h ('k') | extensions/browser/api/sockets_tcp/sockets_tcp_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/socket/udp_socket.h
diff --git a/extensions/browser/api/socket/udp_socket.h b/extensions/browser/api/socket/udp_socket.h
index 8874603bf41fbcf4b1699cd2a6fd25ac0d3f59b4..7a51131ddb8cf3fe6ac00ada847f5dfd1d5fff0f 100644
--- a/extensions/browser/api/socket/udp_socket.h
+++ b/extensions/browser/api/socket/udp_socket.h
@@ -16,27 +16,26 @@ namespace extensions {
class UDPSocket : public Socket {
public:
explicit UDPSocket(const std::string& owner_extension_id);
- virtual ~UDPSocket();
-
- virtual void Connect(const std::string& address,
- int port,
- const CompletionCallback& callback) override;
- virtual void Disconnect() override;
- virtual int Bind(const std::string& address, int port) override;
- virtual void Read(int count, const ReadCompletionCallback& callback) override;
- virtual void RecvFrom(int count,
- const RecvFromCompletionCallback& callback) override;
- virtual void SendTo(scoped_refptr<net::IOBuffer> io_buffer,
- int byte_count,
- const std::string& address,
- int port,
- const CompletionCallback& callback) override;
-
- virtual bool IsConnected() override;
-
- virtual bool GetPeerAddress(net::IPEndPoint* address) override;
- virtual bool GetLocalAddress(net::IPEndPoint* address) override;
- virtual Socket::SocketType GetSocketType() const override;
+ ~UDPSocket() override;
+
+ void Connect(const std::string& address,
+ int port,
+ const CompletionCallback& callback) override;
+ void Disconnect() override;
+ int Bind(const std::string& address, int port) override;
+ void Read(int count, const ReadCompletionCallback& callback) override;
+ void RecvFrom(int count, const RecvFromCompletionCallback& callback) override;
+ void SendTo(scoped_refptr<net::IOBuffer> io_buffer,
+ int byte_count,
+ const std::string& address,
+ int port,
+ const CompletionCallback& callback) override;
+
+ bool IsConnected() override;
+
+ bool GetPeerAddress(net::IPEndPoint* address) override;
+ bool GetLocalAddress(net::IPEndPoint* address) override;
+ Socket::SocketType GetSocketType() const override;
bool IsBound();
@@ -49,9 +48,9 @@ class UDPSocket : public Socket {
const std::vector<std::string>& GetJoinedGroups() const;
protected:
- virtual int WriteImpl(net::IOBuffer* io_buffer,
- int io_buffer_size,
- const net::CompletionCallback& callback) override;
+ int WriteImpl(net::IOBuffer* io_buffer,
+ int io_buffer_size,
+ const net::CompletionCallback& callback) override;
private:
// Make net::IPEndPoint can be refcounted
@@ -82,7 +81,7 @@ class ResumableUDPSocket : public UDPSocket {
explicit ResumableUDPSocket(const std::string& owner_extension_id);
// Overriden from ApiResource
- virtual bool IsPersistent() const override;
+ bool IsPersistent() const override;
const std::string& name() const { return name_; }
void set_name(const std::string& name) { name_ = name; }
« no previous file with comments | « extensions/browser/api/socket/tls_socket.h ('k') | extensions/browser/api/sockets_tcp/sockets_tcp_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698