Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: extensions/browser/api/serial/serial_connection.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/serial/serial_connection.cc
diff --git a/extensions/browser/api/serial/serial_connection.cc b/extensions/browser/api/serial/serial_connection.cc
index f1963e60d8e27d164e18e6c5d339ba515df1b0aa..cbf92a6feaef26228d9521454d8cd57bf1fb8fc2 100644
--- a/extensions/browser/api/serial/serial_connection.cc
+++ b/extensions/browser/api/serial/serial_connection.cc
@@ -139,15 +139,13 @@ class SendBuffer : public device::ReadOnlyBuffer {
const std::string& data,
const base::Callback<void(int, device::serial::SendError)>& callback)
: data_(data), callback_(callback) {}
- virtual ~SendBuffer() {}
- virtual const char* GetData() override { return data_.c_str(); }
- virtual uint32_t GetSize() override {
- return static_cast<uint32_t>(data_.size());
- }
- virtual void Done(uint32_t bytes_read) override {
+ ~SendBuffer() override {}
+ const char* GetData() override { return data_.c_str(); }
+ uint32_t GetSize() override { return static_cast<uint32_t>(data_.size()); }
+ void Done(uint32_t bytes_read) override {
callback_.Run(bytes_read, device::serial::SEND_ERROR_NONE);
}
- virtual void DoneWithError(uint32_t bytes_read, int32_t error) override {
+ void DoneWithError(uint32_t bytes_read, int32_t error) override {
callback_.Run(bytes_read, static_cast<device::serial::SendError>(error));
}
@@ -163,13 +161,13 @@ class ReceiveBuffer : public device::WritableBuffer {
uint32_t size,
const base::Callback<void(int, device::serial::ReceiveError)>& callback)
: buffer_(buffer), size_(size), callback_(callback) {}
- virtual ~ReceiveBuffer() {}
- virtual char* GetData() override { return buffer_->data(); }
- virtual uint32_t GetSize() override { return size_; }
- virtual void Done(uint32_t bytes_written) override {
+ ~ReceiveBuffer() override {}
+ char* GetData() override { return buffer_->data(); }
+ uint32_t GetSize() override { return size_; }
+ void Done(uint32_t bytes_written) override {
callback_.Run(bytes_written, device::serial::RECEIVE_ERROR_NONE);
}
- virtual void DoneWithError(uint32_t bytes_written, int32_t error) override {
+ void DoneWithError(uint32_t bytes_written, int32_t error) override {
callback_.Run(bytes_written,
static_cast<device::serial::ReceiveError>(error));
}
« no previous file with comments | « extensions/browser/api/serial/serial_connection.h ('k') | extensions/browser/api/serial/serial_event_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698