extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.h ('k') | extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h

diff --git a/extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h b/extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h

index 82d2e49fdcd0ca050bf947b977f9bf9d8a26df51..81ad18c0ba9aa8d2fca404b37cb77ac94c67fc17 100644

--- a/extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h

+++ b/extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h

@@ -41,7 +41,7 @@ class BluetoothApiSocket : public ApiResource {

scoped_refptr<device::BluetoothSocket> socket,

const std::string& device_address,

const device::BluetoothUUID& uuid);

- virtual ~BluetoothApiSocket();

+ ~BluetoothApiSocket() override;

// Adopts a socket |socket| connected to a device with address

// |device_address| using the service with UUID |uuid|.

@@ -89,7 +89,7 @@ class BluetoothApiSocket : public ApiResource {

const device::BluetoothUUID& uuid() const { return uuid_; }

// Overriden from extensions::ApiResource.

- virtual bool IsPersistent() const override;

+ bool IsPersistent() const override;

const std::string* name() const { return name_.get(); }

void set_name(const std::string& name) { name_.reset(new std::string(name)); }