Issue 664923003: Allow QUIC's BBR TCP sender to pace based on min rtt and add an explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664923003: Allow QUIC's BBR TCP sender to pace based on min rtt and add an explicit (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Removing_QUIC_VERSION_18_77603158

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow QUIC's BBR TCP sender to pace based on min rtt and add an explicit PacingRate() method to SendAlgorithmInterface for BBR. Merge internal change: 77668996 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -36 lines)			Patch
M	net/quic/congestion_control/pacing_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender_test.cc	View	4 chunks	+12 lines, -26 lines	0 comments	Download
M	net/quic/congestion_control/send_algorithm_interface.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

6 years, 2 months ago (2014-10-20 17:53:45 UTC) #2

LGTM

This CL introduced (or exposed) some divide by zero errors. We should make sure
to also land the fixes at the same time.

Expand Messages | Collapse Messages