history: more VoiceOver enhancements.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 169 matching lines @@
 Visit.prototype.getResultDOM = function(propertyBag) {
   var isSearchResult = propertyBag.isSearchResult || false;
   var addTitleFavicon = propertyBag.addTitleFavicon || false;
   var useMonthDate = propertyBag.useMonthDate || false;
   var focusless = propertyBag.focusless || false;
   var node = createElementWithClassName('li', 'entry');
   var time = createElementWithClassName('span', 'time');
   var entryBox = createElementWithClassName('div', 'entry-box');
   var domain = createElementWithClassName('div', 'domain');
 
-  this.id_ = this.model_.nextVisitId_++;
+  this.id_ = this.model_.getNextVisitId();
   var self = this;
 
   // Only create the checkbox if it can be used either to delete an entry or to
   // block/allow it.
   if (this.model_.editingEntriesAllowed) {
     var checkbox = document.createElement('input');
     checkbox.type = 'checkbox';
     checkbox.id = 'checkbox-' + this.id_;
-    checkbox.setAttribute('aria-label',
-                          loadTimeData.getString('removeFromHistory'));
     checkbox.time = this.date.getTime();
+
+    var summaryFields = [this.dateTimeOfDay, this.title_, this.domain_];
+    checkbox.setAttribute('aria-label', summaryFields.join('\n'));

[dmazzoni, 2014/10/21 05:11:33]

Maybe join with comma and space? This will get rendered in braille for some
users and a newline seems excessive.

[Dan Beam, 2014/10/21 05:14:03]

This was the only way that I thought would have a prayer of localizing well. I
don't know if comma+space works well in all languages.

+
     checkbox.addEventListener('click', checkboxClicked);
     entryBox.appendChild(checkbox);
 
     if (focusless)
       checkbox.tabIndex = -1;
 
     if (!isMobileVersion()) {
       // Clicking anywhere in the entryBox will check/uncheck the checkbox.
       entryBox.setAttribute('for', checkbox.id);
       entryBox.addEventListener('mousedown', entryBoxMousedown);
@@ skipping 524 matching lines @@
 /**
  * Removes |visit| from this model.
  * @param {Visit} visit A visit to remove.
  */
 HistoryModel.prototype.removeVisit = function(visit) {
   var index = this.visits_.indexOf(visit);
   if (index >= 0)
     this.visits_.splice(index, 1);
 };
 
+/**
+ * Automatically generates a new visit ID.
+ * @return {number} The next visit ID.
+ */
+HistoryModel.prototype.getNextVisitId = function() {
+  return this.nextVisitId_++;
+};
+
 // HistoryModel, Private: -----------------------------------------------------
 
 /**
  * Clear the history model.
  * @private
  */
 HistoryModel.prototype.clearModel_ = function() {
   this.inFlight_ = false;  // Whether a query is inflight.
   this.searchText_ = '';
   // Whether this user is a supervised user.
@@ skipping 1516 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });