mac: Fix TestGTMSMJobSubmitRemove on Yosemite.

chrome/browser/service_process/service_process_control_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <launch.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/launchd.h"
 #include "base/mac/scoped_nsobject.h"
+#include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/google_toolbox_for_mac/src/Foundation/GTMServiceManagement.h"
 
 namespace {
 
 // Returns the parameters needed to launch a really simple script from launchd.
 NSDictionary* TestJobDictionary(NSString* label_ns) {
   NSString* shell_script_ns = @"sleep 10; echo TestGTMSMJobSubmitRemove";
   base::scoped_nsobject<NSMutableArray> job_arguments(
       [[NSMutableArray alloc] init]);
@@ skipping 31 matching lines @@
   NSDictionary* job_dictionary_ns = TestJobDictionary(label_ns);
   CFDictionaryRef job_dictionary_cf = base::mac::NSToCFCast(job_dictionary_ns);
   ASSERT_TRUE(GTMSMJobSubmit(job_dictionary_cf, &error));
 
   // The new job should be running.
   pid = base::mac::PIDForJob(label);
   EXPECT_GT(pid, 0);
 
   // Remove the job.
   ASSERT_TRUE(GTMSMJobRemove(label_cf, &error));
-  pid = base::mac::PIDForJob(label);
+
+  // Wait for the job to be killed.
+  base::TimeDelta timeout_in_ms = base::TimeDelta::FromMilliseconds(1000);

[Scott Byer, 2015/01/31 00:18:15]

IIRC, there are some testing time constants hanging around somewhere - see if
there's an appropriate one. They're there because they get bigger on the
(slow/overloaded) bots.

[erikchen, 2015/01/31 00:52:05]

Found the class "TestTimeouts" and updated the code.

+  base::Time start_time = base::Time::Now();
+  while (1) {
+    pid = base::mac::PIDForJob(label);
+    if (pid < 0)
+      break;
+
+    base::Time current_time = base::Time::Now();
+    if (current_time - start_time > timeout_in_ms)
+      break;
+  }
+
   EXPECT_LT(pid, 0);
 
   // Attempting to remove the job again should fail.
   EXPECT_FALSE(GTMSMJobRemove(label_cf, &error));
 }