mac: Fix TestGTMSMJobSubmitRemove on Yosemite.

chrome/browser/service_process/service_process_control_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <launch.h>
 
 #include "base/mac/launchd.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/google_toolbox_for_mac/src/Foundation/GTMServiceManagement.h"
 
 namespace {
 
 // Returns the parameters needed to launch a really simple script from launchd.
 NSDictionary* TestJobDictionary(NSString* label_ns) {
-  NSString* shell_script_ns = @"sleep 10; echo TestGTMSMJobSubmitRemove";
+  NSString* shell_script_ns = @"echo TestGTMSMJobSubmitRemove";
   base::scoped_nsobject<NSMutableArray> job_arguments(
       [[NSMutableArray alloc] init]);
   [job_arguments addObject:@"/bin/sh"];
   [job_arguments addObject:@"-c"];
   [job_arguments addObject:shell_script_ns];
 
   NSMutableDictionary* job_dictionary_ns = [NSMutableDictionary dictionary];
   [job_dictionary_ns setObject:label_ns forKey:@LAUNCH_JOBKEY_LABEL];
   [job_dictionary_ns setObject:[NSNumber numberWithBool:YES]
                         forKey:@LAUNCH_JOBKEY_RUNATLOAD];
@@ skipping 21 matching lines @@
 
   // Submit a new job.
   NSDictionary* job_dictionary_ns = TestJobDictionary(label_ns);
   CFDictionaryRef job_dictionary_cf = base::mac::NSToCFCast(job_dictionary_ns);
   ASSERT_TRUE(GTMSMJobSubmit(job_dictionary_cf, &error));
 
   // The new job should be running.
   pid = base::mac::PIDForJob(label);
   EXPECT_GT(pid, 0);
 
+  // In Yosemite, the behavior of launch_msg() has changed. Using it to remove
+  // a job that is still in progress succeeds, but the function still returns
+  // an error message: "The operation couldn’t be completed. Operation now in
+  // progress". This logic waits for the job to finish running to avoid
+  // triggering the error message.
+  if (base::mac::IsOSYosemiteOrLater()) {
+    while(true) {
+      pid = base::mac::PIDForJob(label);
+      if (pid == 0)
+        break;
+    }
+  }
+
   // Remove the job.
   ASSERT_TRUE(GTMSMJobRemove(label_cf, &error));

[Mark Mentovai, 2014/10/20 20:24:38]

Shouldn’t we fix GTMSMJobRemove() instead?

[erikchen, 2014/10/21 00:13:25]

I looked more into this. GTMSMJobRemove() is a thin wrapper around launch_msg(),
which is deprecated in Yosemite. I imagine the correct solution is to move to
supported, modern OSX APIs such as XPC services and Launch Agents. 

Are you expecting to see a migration to the more modern APIs, or were you
thinking more along the line of hacks to GTMSMJobRemove() to get it to not
return an error message for this specific use case? 

   pid = base::mac::PIDForJob(label);
   EXPECT_LT(pid, 0);
 
   // Attempting to remove the job again should fail.
   EXPECT_FALSE(GTMSMJobRemove(label_cf, &error));
 }