Web MIDI: notify JavaScript of device connection events

Web MIDI: notify JavaScript of device connection events

Call Blink API to notify JavaScript of device connection
status.

BUG=279097
Committed: https://crrev.com/4046475977c58ae3d5d965efba8a132c12fb3a88
Cr-Commit-Position: refs/heads/master@{#317568}

[Takashi Toyoshima, 2014-10-23 11:14:11]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2014-10-24 03:50:36]

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:183: inputs_[inputs_.size() - 1],
active));
You can use inputs_.back().

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:183: inputs_[inputs_.size() - 1],
active));
Again, I think this can cause a race, because inputs_ can be cleared in the main
thread.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:194: outputs_[outputs_.size() -
1], active));
ditto (for both points)

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:203:
main_message_loop_->PostTask(FROM_HERE,
ditto (for race)

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:245: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
You can use the range based for.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:257: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
ditto

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:264: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
ditto

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:271: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
ditto

[Takashi Toyoshima, 2015-02-21 11:26:56]

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:183: inputs_[inputs_.size() - 1],
active));
On 2014/10/24 03:50:35, yhirano wrote:
> You can use inputs_.back().

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:183: inputs_[inputs_.size() - 1],
active));
On 2014/10/24 03:50:35, yhirano wrote:
> Again, I think this can cause a race, because inputs_ can be cleared in the
main
> thread.

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:194: outputs_[outputs_.size() -
1], active));
On 2014/10/24 03:50:35, yhirano wrote:
> ditto (for both points)

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:203:
main_message_loop_->PostTask(FROM_HERE,
On 2014/10/24 03:50:35, yhirano wrote:
> ditto (for race)

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:245: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
On 2014/10/24 03:50:35, yhirano wrote:
> You can use the range based for.

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:257: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
On 2014/10/24 03:50:35, yhirano wrote:
> ditto

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:264: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
On 2014/10/24 03:50:35, yhirano wrote:
> ditto

Done.

https://codereview.chromium.org/664853003/diff/1/content/renderer/media/midi_...
content/renderer/media/midi_message_filter.cc:271: for (ClientsSet::iterator it
= clients_.begin(); it != clients_.end(); ++it)
On 2014/10/24 03:50:35, yhirano wrote:
> ditto

Done.

[Takashi Toyoshima, 2015-02-21 11:44:54]

ptal on a renewed patch set 2.

[yhirano, 2015-02-23 09:03:28]

lgtm

[Takashi Toyoshima, 2015-02-23 10:46:27]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:46:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664853003/20001

[commit-bot: I haz the power, 2015-02-23 11:33:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-23 11:34:01]

Patchset 2 (id:??) landed as
https://crrev.com/4046475977c58ae3d5d965efba8a132c12fb3a88
Cr-Commit-Position: refs/heads/master@{#317568}