fontSelector should be reset when removing stylesheets which has @font-face rule.

Source/core/dom/StyleSheetCollection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
@@ skipping 11 matching lines @@
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/dom/StyleSheetCollection.h"
 
 #include "core/css/CSSStyleSheet.h"
 #include "core/css/StyleInvalidationAnalysis.h"
+#include "core/css/StyleRuleImport.h"
 #include "core/css/StyleSheetContents.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/StyleEngine.h"
 #include "core/html/HTMLStyleElement.h"
 #include "core/page/Settings.h"
 
 namespace WebCore {
 
@@ skipping 71 matching lines @@
             hasActiveLoadingStylesheet = true;
     }
     if (m_hadActiveLoadingStylesheet && !hasActiveLoadingStylesheet) {
         m_hadActiveLoadingStylesheet = false;
         return true;
     }
     m_hadActiveLoadingStylesheet = hasActiveLoadingStylesheet;
     return false;
 }
 
-void StyleSheetCollection::analyzeStyleSheetChange(StyleResolverUpdateMode updateMode, const Vector<RefPtr<CSSStyleSheet> >& oldStyleSheets, const Vector<RefPtr<CSSStyleSheet> >& newStyleSheets, StyleResolverUpdateType& styleResolverUpdateType, bool& requiresFullStyleRecalc)
+static bool rulesHaveFontFaceRule(const Vector<RefPtr<StyleRuleBase> >& rules)
+{
+    for (unsigned i = 0; i < rules.size(); ++i) {
+        StyleRuleBase* rule = rules[i].get();
+        ASSERT(rule);
+        if (rule->isFontFaceRule())
+            return true;
+    }
+    return false;
+}
+
+static bool styleSheetContentsHasFontFaceRule(StyleSheetContents* sheet)
+{
+    if (!sheet)
+        return false;
+
+    if (sheet->importRules().size() > 0) {
+        const Vector<RefPtr<StyleRuleImport> >& importRules = sheet->importRules();
+        for (unsigned i = 0; i < importRules.size(); ++i) {
+            StyleRuleImport* importRule = importRules[i].get();
+            if (styleSheetContentsHasFontFaceRule(importRule->styleSheet()))
+                return true;
+        }
+    }
+    return rulesHaveFontFaceRule(sheet->childRules());
+}
+
+static bool styleSheetContentsHasFontFaceRule(Vector<StyleSheetContents*> sheets)
+{
+    for (unsigned i =  0; i < sheets.size(); ++i) {
+        if (styleSheetContentsHasFontFaceRule(sheets[i]))
+            return true;
+    }
+    return false;
+}
+
+void StyleSheetCollection::analyzeStyleSheetChange(StyleResolverUpdateMode updateMode, const Vector<RefPtr<CSSStyleSheet> >& oldStyleSheets, const Vector<RefPtr<CSSStyleSheet> >& newStyleSheets, StyleResolverUpdateType& styleResolverUpdateType, bool& requiresFullStyleRecalc, bool& requiresResetFontSelector)
 {
     styleResolverUpdateType = Reconstruct;
     requiresFullStyleRecalc = true;
+    requiresResetFontSelector = true;
 
     if (activeLoadingStyleSheetLoaded(newStyleSheets))
         return;
 
     if (updateMode != AnalyzedStyleUpdate)
         return;
     if (!document()->styleResolverIfExists())
         return;
 
     // Find out which stylesheets are new.
     Vector<StyleSheetContents*> addedSheets;
     if (oldStyleSheets.size() <= newStyleSheets.size()) {
         styleResolverUpdateType = compareStyleSheets(oldStyleSheets, newStyleSheets, addedSheets);
+        requiresResetFontSelector = false;
     } else {
         StyleResolverUpdateType updateType = compareStyleSheets(newStyleSheets, oldStyleSheets, addedSheets);
         styleResolverUpdateType = updateType != Additive ? updateType : Reset;
+        requiresResetFontSelector = updateType != Additive ? true : styleSheetContentsHasFontFaceRule(addedSheets);

[dglazkov, 2013/11/08 18:05:34]

I am not super-thrilled about adding this recursive check. Is there any way
stylesheetcontents could carry a flag that is updated when a fontfacerule is
added?

[tasak, 2013/11/12 04:13:11]

Done.

     }
 
     // FIXME: If styleResolverUpdateType is still Reconstruct, we could return early here
     // as destroying the StyleResolver will recalc the whole document anyway?
 
     // If we are already parsing the body and so may have significant amount of elements, put some effort into trying to avoid style recalcs.
     if (!document()->body() || document()->hasNodesWithPlaceholderStyle())
         return;
     StyleInvalidationAnalysis invalidationAnalysis(addedSheets);
     if (invalidationAnalysis.dirtiesAllStyle())
@@ skipping 24 matching lines @@
     }
     return false;
 }
 
 void StyleSheetCollection::updateUsesRemUnits()
 {
     m_usesRemUnits = styleSheetsUseRemUnits(m_activeAuthorStyleSheets);
 }
 
 }