Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 664823003: Revert of Use approximate scratch textures for image filters. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Use approximate scratch textures for image filters. (patchset #1 id:1 of https://codereview.chromium.org/679113004/) Reason for revert: Images change on some machines. Mostly look OK but not sure about imagefiltersbase on N5. Old" http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/11449357083048653160.png New: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/14279906119350384263.png Original issue's description: > Use approximate scratch textures for image filters. > > Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec TBR=senorblanco@google.com,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a9a80e5f427e02efe7289f3784cf047d12a0b5bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Use approximate scratch textures for image filters.
6 years, 1 month ago (2014-10-27 19:58:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664823003/1
6 years, 1 month ago (2014-10-27 19:58:53 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:59:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as a9a80e5f427e02efe7289f3784cf047d12a0b5bd

Powered by Google App Engine
This is Rietveld 408576698