Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 664803003: Update from chromium a8e7c94b1b79a0948d05a1fcfff53391d22ce37a (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.cc
diff --git a/gpu/command_buffer/service/program_manager.cc b/gpu/command_buffer/service/program_manager.cc
index 63a64b7fc49071049cc41bd565174215d64a39df..ac7021ad7f752a2ecd4bf312378e6df77f5f2416 100644
--- a/gpu/command_buffer/service/program_manager.cc
+++ b/gpu/command_buffer/service/program_manager.cc
@@ -81,8 +81,8 @@ bool GetUniformNameSansElement(
return true;
}
-bool IsBuiltInVarying(const std::string& name) {
- // Built-in variables.
+bool IsBuiltInFragmentVarying(const std::string& name) {
+ // Built-in variables for fragment shaders.
const char* kBuiltInVaryings[] = {
"gl_FragCoord",
"gl_FrontFacing",
@@ -95,6 +95,14 @@ bool IsBuiltInVarying(const std::string& name) {
return false;
}
+bool IsBuiltInInvariant(
+ const VaryingMap& varyings, const std::string& name) {
+ VaryingMap::const_iterator hit = varyings.find(name);
+ if (hit == varyings.end())
+ return false;
+ return hit->second.isInvariant;
+}
+
} // anonymous namespace.
Program::UniformInfo::UniformInfo()
@@ -526,6 +534,11 @@ bool Program::Link(ShaderManager* manager,
set_log_info(ProcessLogInfo(info_log).c_str());
return false;
}
+ if (DetectBuiltInInvariantConflicts()) {
+ set_log_info("Invariant settings for certain built-in varyings "
+ "have to match");
+ return false;
+ }
if (DetectGlobalNameConflicts(&conflicting_name)) {
std::string info_log = "Name conflicts between an uniform and an "
"attribute: " + conflicting_name;
@@ -1071,7 +1084,7 @@ bool Program::DetectVaryingsMismatch(std::string* conflicting_name) const {
for (VaryingMap::const_iterator iter = fragment_varyings->begin();
iter != fragment_varyings->end(); ++iter) {
const std::string& name = iter->first;
- if (IsBuiltInVarying(name))
+ if (IsBuiltInFragmentVarying(name))
continue;
VaryingMap::const_iterator hit = vertex_varyings->find(name);
@@ -1092,6 +1105,28 @@ bool Program::DetectVaryingsMismatch(std::string* conflicting_name) const {
return false;
}
+bool Program::DetectBuiltInInvariantConflicts() const {
+ DCHECK(attached_shaders_[0].get() &&
+ attached_shaders_[0]->shader_type() == GL_VERTEX_SHADER &&
+ attached_shaders_[1].get() &&
+ attached_shaders_[1]->shader_type() == GL_FRAGMENT_SHADER);
+ const VaryingMap& vertex_varyings = attached_shaders_[0]->varying_map();
+ const VaryingMap& fragment_varyings = attached_shaders_[1]->varying_map();
+
+ bool gl_position_invariant = IsBuiltInInvariant(
+ vertex_varyings, "gl_Position");
+ bool gl_point_size_invariant = IsBuiltInInvariant(
+ vertex_varyings, "gl_PointSize");
+
+ bool gl_frag_coord_invariant = IsBuiltInInvariant(
+ fragment_varyings, "gl_FragCoord");
+ bool gl_point_coord_invariant = IsBuiltInInvariant(
+ fragment_varyings, "gl_PointCoord");
+
+ return ((gl_frag_coord_invariant && !gl_position_invariant) ||
+ (gl_point_coord_invariant && !gl_point_size_invariant));
+}
+
bool Program::DetectGlobalNameConflicts(std::string* conflicting_name) const {
DCHECK(attached_shaders_[0].get() &&
attached_shaders_[0]->shader_type() == GL_VERTEX_SHADER &&
@@ -1130,7 +1165,7 @@ bool Program::CheckVaryingsPacking(
iter != fragment_varyings->end(); ++iter) {
if (!iter->second.staticUse && option == kCountOnlyStaticallyUsed)
continue;
- if (!IsBuiltInVarying(iter->first)) {
+ if (!IsBuiltInFragmentVarying(iter->first)) {
VaryingMap::const_iterator vertex_iter =
vertex_varyings->find(iter->first);
if (vertex_iter == vertex_varyings->end() ||
« no previous file with comments | « gpu/command_buffer/service/program_manager.h ('k') | gpu/command_buffer/service/shader_translator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698