courgette/disassembler_elf_32_x86.cc - Issue 664803002: Fix courgette ELF x86 dissembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86.cc

Issue 664803002: Fix courgette ELF x86 dissembler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: rogue extra line Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_x86.cc

diff --git a/courgette/disassembler_elf_32_x86.cc b/courgette/disassembler_elf_32_x86.cc

index 74496d3ca2dc94ca8395abc215b7ba5a16fcae52..d2c1c86b440a4c1f5faa7e4f93c132a7fdc5bb67 100644

--- a/courgette/disassembler_elf_32_x86.cc

+++ b/courgette/disassembler_elf_32_x86.cc

@@ -91,6 +91,9 @@ CheckBool DisassemblerElf32X86::ParseRelocationSection(

uint32 section_relocs_count = section_header->sh_size /

section_header->sh_entsize;

+ if (abs32_locations_.empty())

+ match = false;

if (abs32_locations_.size() > section_relocs_count)

match = false;