Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 664793002: Rename and refactor DownloadCurrentBuild and related functions. (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
Reviewers:
prasadv
CC:
chromium-reviews, Sergiy Byelozyorov, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename and refactor DownloadCurrentBuild and related functions. This CL renames a couple functions in order to try to more accurately reflect what they do: BuildCurrentRevision -> _ObtainBuild DownloadCurrentBuild -> _DownloadAndUnzipBuild This CL breaks two sub-functions out of DownloadCurrentBuild: _WaitForBuildDownload _UnzipAndMoveBuildProducts Note: Later, I plan to replace _GetBuildArchiveForRevision with fetch_build.FetchBuild, and possibly change _UnzipAndMoveBuildProducts so that it doesn't do unzipping, since unzipping is done in fetch_build.FetchBuild. Either that, or make it so that unzipping isn't done in that function. BUG= Committed: https://crrev.com/472793788cbb265ce69176d0940922262c0649c5 Cr-Commit-Position: refs/heads/master@{#301029}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -55 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 1 2 3 7 chunks +100 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qyearsley
Hey guys, this CL is supposed to break up DownloadCurrentBuild in order to make it ...
6 years, 2 months ago (2014-10-18 01:17:01 UTC) #2
prasadv
lgtm
6 years, 2 months ago (2014-10-23 22:55:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664793002/60001
6 years, 2 months ago (2014-10-24 01:11:24 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-24 02:04:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 02:05:22 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/472793788cbb265ce69176d0940922262c0649c5
Cr-Commit-Position: refs/heads/master@{#301029}

Powered by Google App Engine
This is Rietveld 408576698