Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664713002: DevTools: do not suggest mapping workspace to itself, remove workspace mapping tip from behind expe… (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: do not suggest mapping workspace to itself, remove workspace mapping tip from behind experiments. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/WorkspaceMappingTip.js View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sourcesView.css View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pfeldman
6 years, 2 months ago (2014-10-17 13:39:57 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-20 08:04:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664713002/1
6 years, 2 months ago (2014-10-20 08:04:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32533)
6 years, 2 months ago (2014-10-20 10:15:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664713002/1
6 years, 2 months ago (2014-10-20 11:11:42 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 11:48:42 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183973

Powered by Google App Engine
This is Rietveld 408576698