Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 664693003: DevTools: skip animation when resetting Timeline flame chart to initial state (Closed)

Created:
6 years, 2 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
alph, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: skip animation when resetting Timeline flame chart to initial state Animation will break if endTime is Infinity which is the case when we reset Timeline flame chart time window to initial range [0, Infinity) BUG=424506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/components/FlameChart.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
yurys
6 years, 2 months ago (2014-10-17 12:27:14 UTC) #2
loislo
lgtm
6 years, 2 months ago (2014-10-17 13:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664693003/1
6 years, 2 months ago (2014-10-17 13:14:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29509)
6 years, 2 months ago (2014-10-17 15:23:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664693003/1
6 years, 2 months ago (2014-10-20 06:06:09 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 07:08:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183965

Powered by Google App Engine
This is Rietveld 408576698