Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/mips/instruction-selector-mips.cc ('k') | test/mjsunit/unused-context-in-with.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/generic-node-inl.h" 5 #include "src/compiler/generic-node-inl.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 case CallDescriptor::kCallJSFunction: 757 case CallDescriptor::kCallJSFunction:
758 opcode = kArchCallJSFunction; 758 opcode = kArchCallJSFunction;
759 break; 759 break;
760 default: 760 default:
761 UNREACHABLE(); 761 UNREACHABLE();
762 return; 762 return;
763 } 763 }
764 opcode |= MiscField::encode(descriptor->flags()); 764 opcode |= MiscField::encode(descriptor->flags());
765 765
766 // Emit the call instruction. 766 // Emit the call instruction.
767 InstructionOperand** first_output =
768 buffer.outputs.size() > 0 ? &buffer.outputs.front() : NULL;
767 Instruction* call_instr = 769 Instruction* call_instr =
768 Emit(opcode, buffer.outputs.size(), &buffer.outputs.front(), 770 Emit(opcode, buffer.outputs.size(), first_output,
769 buffer.instruction_args.size(), &buffer.instruction_args.front()); 771 buffer.instruction_args.size(), &buffer.instruction_args.front());
770 call_instr->MarkAsCall(); 772 call_instr->MarkAsCall();
771 } 773 }
772 774
773 775
774 // Shared routine for multiple compare operations. 776 // Shared routine for multiple compare operations.
775 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode, 777 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode,
776 InstructionOperand* left, InstructionOperand* right, 778 InstructionOperand* left, InstructionOperand* right,
777 FlagsContinuation* cont) { 779 FlagsContinuation* cont) {
778 X64OperandGenerator g(selector); 780 X64OperandGenerator g(selector);
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1055 1057
1056 1058
1057 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) { 1059 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
1058 FlagsContinuation cont(kUnorderedLessThanOrEqual, node); 1060 FlagsContinuation cont(kUnorderedLessThanOrEqual, node);
1059 VisitFloat64Compare(this, node, &cont); 1061 VisitFloat64Compare(this, node, &cont);
1060 } 1062 }
1061 1063
1062 } // namespace compiler 1064 } // namespace compiler
1063 } // namespace internal 1065 } // namespace internal
1064 } // namespace v8 1066 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/mips/instruction-selector-mips.cc ('k') | test/mjsunit/unused-context-in-with.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698