Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/compiler/arm64/instruction-selector-arm64.cc

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/instruction-selector-impl.h" 5 #include "src/compiler/instruction-selector-impl.h"
6 #include "src/compiler/node-matchers.h" 6 #include "src/compiler/node-matchers.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 namespace compiler { 10 namespace compiler {
(...skipping 936 matching lines...) Expand 10 before | Expand all | Expand 10 after
947 case CallDescriptor::kCallJSFunction: 947 case CallDescriptor::kCallJSFunction:
948 opcode = kArchCallJSFunction; 948 opcode = kArchCallJSFunction;
949 break; 949 break;
950 default: 950 default:
951 UNREACHABLE(); 951 UNREACHABLE();
952 return; 952 return;
953 } 953 }
954 opcode |= MiscField::encode(descriptor->flags()); 954 opcode |= MiscField::encode(descriptor->flags());
955 955
956 // Emit the call instruction. 956 // Emit the call instruction.
957 InstructionOperand** first_output =
958 buffer.outputs.size() > 0 ? &buffer.outputs.front() : NULL;
957 Instruction* call_instr = 959 Instruction* call_instr =
958 Emit(opcode, buffer.outputs.size(), &buffer.outputs.front(), 960 Emit(opcode, buffer.outputs.size(), first_output,
959 buffer.instruction_args.size(), &buffer.instruction_args.front()); 961 buffer.instruction_args.size(), &buffer.instruction_args.front());
960 call_instr->MarkAsCall(); 962 call_instr->MarkAsCall();
961 } 963 }
962 964
963 965
964 // Shared routine for multiple compare operations. 966 // Shared routine for multiple compare operations.
965 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode, 967 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode,
966 InstructionOperand* left, InstructionOperand* right, 968 InstructionOperand* left, InstructionOperand* right,
967 FlagsContinuation* cont) { 969 FlagsContinuation* cont) {
968 Arm64OperandGenerator g(selector); 970 Arm64OperandGenerator g(selector);
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 1281
1280 1282
1281 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) { 1283 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
1282 FlagsContinuation cont(kUnorderedLessThanOrEqual, node); 1284 FlagsContinuation cont(kUnorderedLessThanOrEqual, node);
1283 VisitFloat64Compare(this, node, &cont); 1285 VisitFloat64Compare(this, node, &cont);
1284 } 1286 }
1285 1287
1286 } // namespace compiler 1288 } // namespace compiler
1287 } // namespace internal 1289 } // namespace internal
1288 } // namespace v8 1290 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm/instruction-selector-arm.cc ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698