[turbofan] decouple register allocation from schedule and graph

[turbofan] decouple register allocation from schedule and graph

R=bmeurer@chromium.org, jarin@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=24717

[dcarney, 2014-10-17 12:55:21]

dcarney@chromium.org changed reviewers:
+ bmeurer@chromium.org

[dcarney, 2014-10-17 12:55:57]

ptal - there's a few follow up cls to clean up, but this completes the
decoupling

[Jarin, 2014-10-17 15:51:59]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2014-10-17 15:52:00]

lgtm

[Benedikt Meurer, 2014-10-19 18:13:03]

LGTM with comments.

https://codereview.chromium.org/664683002/diff/170001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (left):

https://codereview.chromium.org/664683002/diff/170001/src/compiler/instructio...
src/compiler/instruction-selector.cc:855: // TODO(bmeurer): Emit a
PhiInstruction here.
Remove this TODO.

https://codereview.chromium.org/664683002/diff/170001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/664683002/diff/170001/src/compiler/instructio...
src/compiler/instruction-selector.cc:861: for (Node::Inputs::iterator
iter(inputs.begin()); iter != inputs.end();
How about this instead?

const int input_count = node->op()->InputCount();
phi->operands().reserve(static_cast<size_t>(input_count));
for (int i = 0; i < node->op()->InputCount(); ++i) {
  Node* const input = node->InputAt(i);
  MarkAsUsed(input);
  phi->operands().push_back(sequence()->GetVirtualRegister(input));
}

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
src/compiler/register-allocator.cc:533: for
(InstructionBlock::Successors::const_iterator i =
s/InstructionBlock::Successors::const_iterator/auto/

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
src/compiler/register-allocator.cc:546: for
(InstructionBlock::PhiInstructions::const_iterator j =
s/InstructionBlock::PhiInstructions::const_iterator/auto/

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
src/compiler/register-allocator.cc:771: for
(InstructionBlock::Successors::const_iterator succ =
s/InstructionBlock::Successors::const_iterator/auto/

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
src/compiler/register-allocator.cc:790: for
(InstructionBlock::Successors::const_iterator succ =
s/InstructionBlock::Successors::const_iterator/auto/

https://codereview.chromium.org/664683002/diff/170001/src/compiler/register-a...
src/compiler/register-allocator.cc:1064: for
(InstructionBlock::PhiInstructions::const_iterator i =
s/InstructionBlock::PhiInstructions::const_iterator/auto/

[dcarney, 2014-10-20 07:32:15]

Committed patchset #13 (id:210001) manually as 24717 (presubmit successful).