Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 664663004: Roll BoringSSL. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll BoringSSL. This pulls in the following changes, including Windows build fixes. It also gets Win32 assembly working. 03a739d Build Win32 with Yasm rather than MASM. 3e700bb Get MASM output working on Win32. 2a0f342 Fix standalone bio_test and v3name_test on Win64. 5f51c25 Add -cipher option to bssl client. 8f1ef1d Fix double-frees on malloc failure in ssl3_get_client_key_exchange. 93d67d3 Refactor ssl3_send_client_key_exchange slightly. 2af684f Add tests for ECDHE_PSK. 491956c Fix ECDHE_PSK key exchange. 48cae08 Add tests for PSK cipher suites. b06711c Move the X509_NAME typedef into x509.h. e167976 Make EVP_DigestVerifyFinal return only zero or one. 3cac450 Add SSL_SESSION_to_bytes to replace i2d_SSL_SESSION. 773bb55 Fix build (broken by removal of key_arg from SSL_SESSION parsing). eb380a4 Fix build on Windows. aeb8d00 Add less dangerous versions of SRTP functions. 7001a7f Don't bother accepting key_arg when parsing SSL_SESSION. 3b73c18 Fix "integer constant is too large for 'long' type" errors. 7571292 Extended master secret support. 89abaea Reimplement i2d_SSL_SESSION using CBB. 83fd6b6 Reimplement d2i_SSL_SESSION with CBS. fbe6f49 The empty contents are not a valid ASN.1 INTEGER. b5b6854 Add CBB_add_asn1_uint64. 9f2c0d7 Remove T** parameter to ssl_bytes_to_cipher_list. 2a39eae Don't condition on another header's #include guard. BUG=338884, 418820 Committed: https://crrev.com/49baca7413237e73d99d9b959fe1dae93e854c0d Cr-Commit-Position: refs/heads/master@{#302016}

Patch Set 1 #

Patch Set 2 : include X509_NAME movement too #

Patch Set 3 : first go at pulling in win32 assembly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17034 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/aes/aes-586.asm View 1 2 1 chunk +3219 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/aes/aesni-x86.asm View 1 2 1 chunk +2170 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/aes/vpaes-x86.asm View 1 2 1 chunk +649 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/bn/bn-586.asm View 1 2 1 chunk +1384 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/bn/co-586.asm View 1 2 1 chunk +1260 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/bn/x86-mont.asm View 1 2 1 chunk +349 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/cpu-x86-asm.asm View 1 2 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/md5/md5-586.asm View 1 2 1 chunk +691 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/modes/ghash-x86.asm View 1 2 1 chunk +1265 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/rc4/rc4-586.asm View 1 2 1 chunk +382 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/sha/sha1-586.asm View 1 2 1 chunk +1392 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/sha/sha256-586.asm View 1 2 1 chunk +3362 lines, -0 lines 0 comments Download
A third_party/boringssl/win-x86/crypto/sha/sha512-586.asm View 1 2 1 chunk +577 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
davidben
This is to pick up the Windows build fix and also the EVP_DigestVerifyFinal return value ...
6 years, 1 month ago (2014-10-28 21:21:07 UTC) #2
davidben
Now that https://boringssl-review.googlesource.com/#/c/2091/ and https://boringssl-review.googlesource.com/#/c/2092/ are in the pipeline, may as well hold on this ...
6 years, 1 month ago (2014-10-29 23:05:59 UTC) #3
agl
Have landed those two changes. I expect some of the asm will change in this ...
6 years, 1 month ago (2014-10-29 23:15:03 UTC) #4
davidben
On 2014/10/29 23:15:03, agl wrote: > Have landed those two changes. I expect some of ...
6 years, 1 month ago (2014-10-30 00:09:21 UTC) #5
agl
lgtm
6 years, 1 month ago (2014-10-30 00:10:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664663004/40001
6 years, 1 month ago (2014-10-30 01:08:04 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 01:51:47 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 01:53:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49baca7413237e73d99d9b959fe1dae93e854c0d
Cr-Commit-Position: refs/heads/master@{#302016}

Powered by Google App Engine
This is Rietveld 408576698