Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 66463002: Fix error message wording when instanceof throws. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fix error message wording when instanceof throws. R=bmeurer@chromium.org BUG=82797, v8:1593 Committed: https://code.google.com/p/v8/source/detail?r=17587

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/message/instanceof.js View 1 chunk +1 line, -2 lines 0 comments Download
A test/message/instanceof.out View 1 chunk +5 lines, -0 lines 0 comments Download
M test/webkit/exception-for-nonobject-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/instance-of-immediates-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look.
7 years, 1 month ago (2013-11-08 10:50:59 UTC) #1
Benedikt Meurer
LGTM
7 years, 1 month ago (2013-11-08 11:37:47 UTC) #2
Yang
7 years, 1 month ago (2013-11-08 11:46:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698