Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: include/lib/fmap.h

Issue 6646016: leverage flashrom fast partial read function to speed up VPD read. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vpd.git@master
Patch Set: refine code to handle corner case of eps->table_address. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/lib/flashrom.h ('k') | include/lib/vpd.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/lib/fmap.h
diff --git a/include/lib/fmap.h b/include/lib/fmap.h
index c6678f7bb1e60aba81413dc810bd6cef8eb94012..cf0955f16b6c4518695c6bcfe0bc1ddd227f79b6 100644
--- a/include/lib/fmap.h
+++ b/include/lib/fmap.h
@@ -81,7 +81,13 @@ struct fmap {
/*
* fmapNormalizeAreaName - to protect malicious attack, this function
- * replace all non-digits and non-alphabet chars into underline.
+ * replace not allowed chars into underline. Only following are allowed:
+ *
+ * numbers
+ * digits
+ * space
+ *
+ * The allowing list should increase if fmap area name allows more chars.
*
* @name: point to the name.
*/
« no previous file with comments | « include/lib/flashrom.h ('k') | include/lib/vpd.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698