Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 664583009: Fix call to _ProfileDir. (Closed)

Created:
6 years, 1 month ago by navabi
Modified:
6 years, 1 month ago
Reviewers:
wuhu, nednguyen, dtu, slamm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix call to _ProfileDir. I think this is a fix to this CL: https://codereview.chromium.org/656383002/ One of the internal bots has the following error: PullProfile at tools/telemetry/telemetry/core/platform/android_platform_backend.py:455 self._ProfileDir(package), output_profile_path) AttributeError: 'AndroidPlatformBackend' object has no attribute '_ProfileDir' There does not seem to be a _ProfileDir, but there is a _GetProfileDir. BUG=417542 Committed: https://crrev.com/0a537a904b0cb14cca715c0588700bc0b52fc53e Cr-Commit-Position: refs/heads/master@{#302169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
navabi
6 years, 1 month ago (2014-10-30 21:01:45 UTC) #2
dtu
lgtm
6 years, 1 month ago (2014-10-30 21:05:44 UTC) #3
wuhu
On 2014/10/30 21:01:45, navabi wrote: LGTM
6 years, 1 month ago (2014-10-30 21:06:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583009/1
6 years, 1 month ago (2014-10-30 21:07:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 22:10:21 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:10:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a537a904b0cb14cca715c0588700bc0b52fc53e
Cr-Commit-Position: refs/heads/master@{#302169}

Powered by Google App Engine
This is Rietveld 408576698